Skip basename() call when finding configs #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2514 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 126 126
Lines 5762 5762
=======================================
Hits 5679 5679
Misses 83 83 ☔ View full report in Codecov by Sentry. |
AshesITR
reviewed
Feb 29, 2024
AshesITR
approved these changes
Feb 29, 2024
AshesITR
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2512. Didn't break any existing tests, so assume it's extraneous as posited.
BTW, I do find it a bit odd that
R_LINTR_LINTER_FILEcan only be set at the R session level (that env is only read in.onLoad()):lintr/R/zzz.R
Lines 294 to 296 in bad1632
Is that WAI? I am not sure the documentation reflects this well, if so:
lintr/R/settings.R
Lines 10 to 11 in bad1632
Therefore to test that
R_LINTR_LINTER_FILEis working under this PR we'd need to invoke a subprocess, that felt like overkill.